This repository was archived by the owner on Jan 17, 2025. It is now read-only.
RFC: use otk files instead of otk.arguments#7
Merged
supakeen merged 1 commit intoosbuild:mainfrom Apr 15, 2024
Merged
Conversation
Member
|
Let's drop the |
The use-case given (and maybe I'm missing other use-cases here) for the otk.arguments is currently "version" and "architecture". We could do this instead via a `fedora-39-amd64.yaml` file that just define those arguments. The upside of this is that we can easily see what combinations of version and architecture we support by looking at the top-level dir. It also simplifies the spec and we would not have to worry about validating arguments, i.e. how do we know that "-Dversion=41" is valid or not (if not valid it would probably mean down the line an include based on the version cannot be found and that presents challenges for a nice error message). It would also allow us to have symlinks when things do not change, e.g. ``` rhel-9.3.yaml -> rhel-9.4.yaml ``` But maybe I'm missing another use case for this? Even then I think the `fedora/39-amd64.yaml` has some merrits and is worth considering.
achilleas-k
force-pushed
the
no-arguments
branch
from
bc9ea02 to
9cf2c4c
Compare
achilleas-k
approved these changes
Apr 12, 2024
Member
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
I really like this simplification. It reduces the scope without limiting functionality.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use-case given (and maybe I'm missing other use-cases here) for the otk.arguments is currently "version" and "architecture".
We could do this instead via a
fedora-39-amd64.yamlfile that just define those arguments. The upside of this is that we can easily see what combinations of version and architecture we support by looking at the top-level dir. It also simplifies the spec and we would not have to worry about validating arguments, i.e. how do we know that "-Dversion=41" is valid or not (if not valid it would probably mean down the line an include based on the version cannot be found and that presents challenges for a nice error message).It would also allow us to have symlinks when things do not change, e.g.
But maybe I'm missing another use case for this? Even then I think the
fedora/39-amd64.yamlhas some merrits and is worth considering.