hackathon: group coding session #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes (some) directives to allow trailing `.tag`'s to work around the issue of duplicate keys not being available. Signed-off-by: Simon de Vlieger <[email protected]>
This was
linked to
issues
May 15, 2024
Closed
These were defined as a group effort during a live programming session on a video call. They're 'how we want things to work', not how things currently work. Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
group-coding-session
branch
from
4ecf0a8
to
f60f090
Compare
mvo5
previously approved these changes
May 15, 2024
example/centos/pipeline/os.yaml
Outdated
| options: | ||
| root_fs_uuid: ${filesystem.root.uuid} | ||
| boot_fs_uuid: ${filesystem.boot.uuid} | ||
| kernel_opts: '{{ " ".join(kernel_opts_list) }}' |
There was a problem hiding this comment.
This might need a "TODO: decide on final syntax"
|
Just for completeness, we will need to go over this again and de-duplicate fedora and centos pipelnes/yamls to see what can be shared and what has to be duplicated but that is obviously follows and we will need tests that compare any refactoring we do to the expected manifests (so for later, but mentioning it for posterity :) |
For consistency with Ansible it's preferable to use underscores instead of dashes for directive names. Signed-off-by: Simon de Vlieger <[email protected]>
After more discussion yesterday this shows an example of how customizations can be used and splits up the pipeline. Signed-off-by: Simon de Vlieger <[email protected]>
|
Added more commits to this based on yesterdays work and discussion. Also did the straightforward change to use underscores in directive names. |
With the future include of conditionals we have decided that modifications will not be special cased in directives but instead will be based on convention in the defines. Signed-off-by: Simon de Vlieger <[email protected]>
Signed-off-by: Simon de Vlieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variety of small tidbits and examples as created during the Hackathon 00 group sessions.