fix GAP.Packages.versioninfo
#1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen that a GAP package is loaded but its directory does not exist. For example, our test that installs/loads/removes a package creates such a GAP session. Calling `GAP.Packages.versioninfo` afterwards ran into an error up to now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 60 60
Lines 4778 4781 +3
==========================================
+ Hits 3675 3678 +3
Misses 1103 1103
🚀 New features to boost your workflow:
|
ThomasBreuer
added a commit
to ThomasBreuer/GAP.jl
that referenced
this pull request
Sep 19, 2025
This reverts commit f8342c1. Now this commit belongs to oscar-system#1246.
lgoettgens
reviewed
Sep 19, 2025
fingolfin
approved these changes
Sep 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that a GAP package is loaded but its directory does not exist.
For example, our test that installs/loads/removes a package creates such a GAP session.
Calling
GAP.Packages.versioninfoafterwards ran into an error up to now.