Skip to content

Conversation

@fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.71%. Comparing base (24e17d6) to head (8809339).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files          61       61           
  Lines        4887     4887           
=======================================
  Hits         3749     3749           
  Misses       1138     1138           
Files with missing lines Coverage Δ
src/conversion.jl 95.23% <100.00%> (ø)
src/gap_to_julia.jl 97.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin requested a review from ThomasBreuer October 1, 2025 06:52
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.k.
My interpretation of the change is:
recursive == true should be viewed as a condition for calling _needs_tracking_gap_to_julia, hence it should be checked before the function call.

@fingolfin fingolfin closed this Oct 1, 2025
@fingolfin fingolfin reopened this Oct 1, 2025
@fingolfin fingolfin enabled auto-merge (rebase) October 1, 2025 09:04
@fingolfin fingolfin merged commit fb6be50 into master Oct 1, 2025
340 of 347 checks passed
@fingolfin fingolfin deleted the mh/_needs_tracking_gap_to_julia branch October 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants