Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SL2.1 #281

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Fix SL2.1 #281

merged 1 commit into from
Mar 31, 2025

Conversation

SoongNoonien
Copy link
Member

This should fix #275. I'm not sure if power is a good name though.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (4d4dcc0) to head (fc6e8d2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   94.91%   94.96%   +0.04%     
==========================================
  Files          13       13              
  Lines         905      913       +8     
==========================================
+ Hits          859      867       +8     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SoongNoonien
Copy link
Member Author

This should also fix #23.

@SoongNoonien
Copy link
Member Author

Ok, I'll go ahead and merge this now and adjust the generic_cyclotomic_ring constructor later accordingly.

@SoongNoonien SoongNoonien merged commit 6ea611b into oscar-system:master Mar 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SL2.1 is broken  Add generic character table for SL(2,q), with q odd and non-square?
1 participant