Revert exponent rationalization efforts #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit quick with those. While converting the 2B2 table locally to rational exponents I noticed many other problems that prevented importing. Finally I could resolve all of these just to notice that the whole concept is flawed. Take a look at
nesum
where it is mathematically necessary to have a well defined multiplication ofmodulusring
elements into theargumentring
. We could work around these by using the mapping betweenq
andq0
but I think this makes things way to complicated.My new idea is now to fully integrate the
congruence
field of the tables into the simplification of the cyclotomics. All tables with nonrational expressions in their character values have a congruence which ensures rationality in the exponents. This way we can use something likechange_base_ring
to ensure rationality while applying the normal form algorithms.@fingolfin I'm not sure if this is how you like reverts to be done but I didn't want to force push to master.