fix: check argument for map of polynomial rings (#4398)

oscar-system · Dec 12, 2024 · 9a4a751 · 9a4a751
1 parent 6b027f0
commit 9a4a751
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Rings/MPolyMap/MPolyQuo.jl b/src/Rings/MPolyMap/MPolyQuo.jl
@@ -152,6 +152,7 @@ end
 # The two main evaluation methods
 function (F::MPolyAnyMap{<: MPolyQuoRing})(g)
   if g isa elem_type(domain(F))
+    @req parent(g) === domain(F) "Element not in domain"
     if coefficient_map(F) === nothing
       return _evaluate_plain(F, g)
     else 

diff --git a/test/Rings/MPolyAnyMap/MPolyQuo.jl b/test/Rings/MPolyAnyMap/MPolyQuo.jl
@@ -212,4 +212,14 @@ end
   # The test is whether the following two lines work at all
   AtoR = @inferred hom(A, R, QtoR, [ x^2, y^2, x*y ])
   @test isone(AtoR(A(1)))
+
+  let
+    Qt, (t,) = polynomial_ring(QQ, [:t])
+    QT, (T,) = polynomial_ring(QQ, [:T])
+    Q1, = quo(Qt, ideal(Qt, [t]))
+    Q2, = quo(QT, ideal(QT, [T^2]))
+    h = hom(Q2, Q1, [Qt(t)])
+    @test_throws ArgumentError h(t)
+  end
+
 end