Remove some redundant base_ring methods (#4408)

* Remove some redundant base_ring methods * VarietyFunctionFieldElem now isa FieldElem
oscar-system · Dec 20, 2024 · cd79a0b · cd79a0b
1 parent 57c1b68
commit cd79a0b
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 9 deletions.
diff --git a/src/AlgebraicGeometry/Schemes/FunctionField/FunctionFields.jl b/src/AlgebraicGeometry/Schemes/FunctionField/FunctionFields.jl
@@ -354,7 +354,6 @@ function parent_type(::Type{T}) where {ParentType, T<:VarietyFunctionFieldElem{<
 end
 
 base_ring(KK::VarietyFunctionField) = base_ring(representative_field(KK))
-base_ring(a::VarietyFunctionFieldElem) = base_ring(parent(a))
 is_domain_type(::Type{T}) where {T<:VarietyFunctionFieldElem} = true
 is_exact_type(::Type{T}) where {T<:VarietyFunctionFieldElem} = true
 

diff --git a/src/AlgebraicGeometry/Schemes/FunctionField/Types.jl b/src/AlgebraicGeometry/Schemes/FunctionField/Types.jl
@@ -30,7 +30,7 @@ end
 ########################################################################
 mutable struct VarietyFunctionFieldElem{FracType<:AbstractAlgebra.Generic.FracFieldElem,
                                         ParentType<:VarietyFunctionField
-                                       }
+                                       } <: FieldElem
   KK::ParentType
   f::FracType
 

diff --git a/src/Rings/PBWAlgebra.jl b/src/Rings/PBWAlgebra.jl
@@ -68,8 +68,6 @@ coefficient_ring(a::PBWAlgElem) = coefficient_ring(parent(a))
 
 base_ring(a::PBWAlgRing) = a.poly_ring
 
-base_ring(a::PBWAlgElem) = base_ring(parent(a))
-
 function Base.deepcopy_internal(a::PBWAlgElem, dict::IdDict)
   return PBWAlgElem(parent(a), deepcopy_internal(a.sdata, dict))
 end

diff --git a/src/Rings/PBWAlgebraQuo.jl b/src/Rings/PBWAlgebraQuo.jl
@@ -85,8 +85,6 @@ base_ring(Q::PBWAlgQuo) = base_ring(Q.I)
 
 base_ring_type(::Type{PBWAlgQuo{T, S}}) where {T, S} = base_ring_type(PBWAlgIdeal{0, T, S})
 
-base_ring(a::PBWAlgQuoElem) = base_ring(parent(a))
-
 function Base.deepcopy_internal(a::PBWAlgQuoElem, dict::IdDict)
   return PBWAlgQuoElem(parent(a), deepcopy_internal(a.data, dict))
 end

diff --git a/src/Rings/mpoly-graded.jl b/src/Rings/mpoly-graded.jl
@@ -1174,8 +1174,6 @@ number_of_generators(W::MPolyDecRing) = number_of_generators(forget_decoration(W
 gens(W::MPolyDecRing) = map(W, gens(forget_decoration(W)))
 gen(W::MPolyDecRing, i::Int) = W(gen(forget_decoration(W), i))
 
-base_ring(f::MPolyDecRingElem) = base_ring(forget_decoration(f))
-
 function show_homo_comp(io::IO, M)
   (W, d) = get_attribute(M, :data)
   n = AbstractAlgebra.get_name(W)

diff --git a/src/Rings/mpolyquo-localizations.jl b/src/Rings/mpolyquo-localizations.jl
@@ -443,7 +443,6 @@ denominator(a::MPolyQuoLocRingElem) = underlying_quotient(parent(a))(a.denominat
 ### additional getter functions
 underlying_quotient(a::MPolyQuoLocRingElem) = underlying_quotient(parent(a))
 localized_ring(a::MPolyQuoLocRingElem) = localized_ring(parent(a))
-base_ring(a::MPolyQuoLocRingElem) = base_ring(parent(a))
 is_reduced(a::MPolyQuoLocRingElem) = a.is_reduced
 
 @doc raw"""