Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for CartanMatrix.jl #4295

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Improve test coverage for CartanMatrix.jl #4295

merged 1 commit into from
Dec 8, 2024

Conversation

felix-roehrich
Copy link
Collaborator

@felix-roehrich felix-roehrich commented Nov 9, 2024 •
edited by lgoettgens
Loading

Increase test coverage of CartanMatrix.jl to prepare for #4263.

Closes #4387

@lgoettgens lgoettgens added topic: LieTheory experimental Only changes experimental parts of the code labels Nov 9, 2024
@lgoettgens

This comment was marked as resolved.

Sign in to view
@lgoettgens lgoettgens mentioned this pull request Dec 7, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (7e93d11) to head (5398b3d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/CartanMatrix.jl 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4295   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         656      656           
  Lines       87194    87201    +7     
=======================================
+ Hits        73575    73583    +8     
+ Misses      13619    13618    -1
Files with missing lines Coverage Δ
experimental/LieAlgebras/test/CartanMatrix-test.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/CartanMatrix.jl 97.57% <96.00%> (+0.27%) ⬆️

lgoettgens
lgoettgens approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgoettgens lgoettgens merged commit 75dd78a into oscar-system:master Dec 8, 2024
30 checks passed
@felix-roehrich felix-roehrich deleted the fr/cartan-test-cov branch December 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens approved these changes

Assignees
No one assigned
Labels
experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-roehrich @lgoettgens