Rename acting_domain to acting_group and some improvements for group cosets
#4302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- access defining data via functions not fields - rename `acting_domain` to `acting_group` - improve documentation - `in` for left/right cosets now delegates to a membership test in a group - iterator for left/right cosets now uses a group iterator
Member
|
@ThomasBreuer does it resolve those PRs completely? Then you can write |
Member
Author
No. |
lgoettgens
reviewed
Nov 13, 2024
Add the type of the *subgroup* as a parameter,
then we can prescribe a better `Base.IteratorSize(::Type{<:GroupCoset})`,
as proposed in oscar-system#4289.
Note that in principle, we could omit the type of the *big group* from the
parameters since it is the `parent_type` of the element type parameter.
(The design of the `GroupCoset` type dates back to the times when
we thought that a group has the same type as its subgroups.
At the time when this idea was given up, I should have changed
`GroupCoset` to take the *subgroup* type as a parameter.)
This was tricky: The error messages were misleading, the problem occurred on a lower level.
Member
Author
|
Run tests / test (1.6, short, ubuntu-latest) failed with a segmentation fault, restarted. |
fingolfin
reviewed
Nov 18, 2024
| function GroupCoset(G::T, H::GAPGroup, representative::S, side::Symbol) where {T<: GAPGroup, S<:GAPGroupElem} | ||
| return new{T, S}(G, H, representative, side, Ref{GapObj}()) | ||
| function GroupCoset(G::TG, H::TH, representative::S, side::Symbol) where {TG <: GAPGroup, TH <: GAPGroup, S <:GAPGroupElem} | ||
| return new{TG, TH, S}(G, H, representative, side, Ref{GapObj}()) |
Member
There was a problem hiding this comment.
Maybe enforce the type relation(s) here, e.g. something like @assert S == elem_type(TG) or so (assuming that's correct)
fingolfin
approved these changes
Nov 18, 2024
fingolfin
changed the title
acting_domain to acting_group and some improvements for group cosets
fingolfin
added
renaming
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acting_domaintoacting_groupinfor left/right cosets now delegates to a membership test in a groupaddresses #4283 and #4289