Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve orbit_representatives_and_stabilizers #4337

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ThomasBreuer
Copy link
Member

On the GAP side, replace the action on subspces by an equivalent action on matrices.

For not too large examples, this yields a speedup.
Big examples suffer from the approach to write down the whole set.
(In the end, we want only orbit representatives.)

On the GAP side, replace the action on subspces by an equivalent
action on matrices.
@ThomasBreuer
Copy link
Member Author

Failure in test (1.10, short, ubuntu-latest):

GC: pause 42.41ms. collected 32.954742MB. incr 
corrupted size vs. prev_size while consolidating

[2001] signal (6.-6): Aborted
in expression starting at /home/runner/work/Oscar.jl/Oscar.jl/experimental/OrthogonalDiscriminants/test/theoretical.jl:53
Error: The operation was canceled.

Restarted this test.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To really get this fast we need a fresh dedicated implementation of subspace stabilizers / representatives, by exploiting the module structure (using the Meataxe). But of course that takes more time so a quick minor improvement is still useful

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (5a737af) to head (000906c).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4337   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         645      645           
  Lines       85621    85624    +3     
=======================================
+ Hits        72354    72357    +3     
  Misses      13267    13267           
Files with missing lines Coverage Δ
src/Groups/gsets.jl 92.35% <100.00%> (+0.07%) ⬆️
---- 🚨 Try these New Features:

@joschmitt joschmitt merged commit 308aeee into oscar-system:master Nov 22, 2024
30 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_orbits_on_subspaces branch November 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants