Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set torusfactor attribute #4385

Merged

Conversation

paemurru
Copy link
Contributor

@paemurru paemurru commented Dec 5, 2024

Blowing up along a ray does not change whether the toric variety has torus factors.

Blowing up along a ray does not change whether the toric variety has torus factors.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (5aec608) to head (5beee62).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
experimental/Schemes/src/ToricBlowups/types.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4385   +/-   ##
=======================================
  Coverage   84.36%   84.37%           
=======================================
  Files         656      656           
  Lines       87209    87206    -3     
=======================================
+ Hits        73573    73578    +5     
+ Misses      13636    13628    -8     
Files with missing lines Coverage Δ
experimental/Schemes/src/ToricBlowups/types.jl 72.13% <75.00%> (+0.20%) ⬆️

... and 10 files with indirect coverage changes

@afkafkafk13
Copy link
Collaborator

Is this attribute used (in particular: set and tested) somewhere? This is at least not obvious from this PR.

@paemurru
Copy link
Contributor Author

paemurru commented Dec 5, 2024

It looks like there is one test for blowup of projective 2-space in test/AlgebraicGeometry/ToricVarieties/toric_blowups.jl that also tests for has_torusfactor.

@afkafkafk13 afkafkafk13 merged commit 5bea91f into oscar-system:master Dec 9, 2024
30 checks passed
@paemurru paemurru deleted the ep/set_torusfactor_attribute branch December 9, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants