Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LieAlgebras: Add section with Dynkin diagrams to docs #4390

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Dec 9, 2024

preview: https://docs.oscar-system.org/previews/PR4390/Experimental/LieAlgebras/cartan_matrix/

The bib-entry for the Bourbaki is still missing (ping @felix-roehrich).

@lgoettgens lgoettgens added documentation Improvements or additions to documentation topic: LieTheory labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (75dd78a) to head (6627fb6).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4390   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         656      656           
  Lines       87201    87198    -3     
=======================================
- Hits        73583    73582    -1     
+ Misses      13618    13616    -2     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/CartanMatrix.jl 97.57% <ø> (ø)
experimental/LieAlgebras/src/DynkinDiagram.jl 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

@lgoettgens lgoettgens marked this pull request as ready for review December 10, 2024 11:22
@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Dec 10, 2024
@lgoettgens lgoettgens requested a review from fingolfin December 10, 2024 11:24
note = {Original French edition published with the title: Éléments de Matematique, Groupes et Algèbres de
Lie 4, 5, e 6, 1968. Translated by Pressley},
publisher = {Springer},
year = {2002}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry from mathScinet, including a DOI:

@book {MR1890629,
    AUTHOR = {Bourbaki, Nicolas},
     TITLE = {Lie groups and {L}ie algebras. {C}hapters 4--6},
    SERIES = {Elements of Mathematics (Berlin)},
      NOTE = {Translated from the 1968 French original by Andrew Pressley},
 PUBLISHER = {Springer-Verlag, Berlin},
      YEAR = {2002},
     PAGES = {xii+300},
      ISBN = {3-540-42650-7},
   MRCLASS = {17-01 (00A05 20E42 20F55 22-01)},
  MRNUMBER = {1890629},
       DOI = {10.1007/978-3-540-89394-3},
       URL = {https://doi.org/10.1007/978-3-540-89394-3},
}

Copy link
Member Author

@lgoettgens lgoettgens Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doi unfortunately results in a soft 404 (which somewhat goes against the idea of dois....)

The entry was taken from springer's webpage

Comment on lines +443 to +451
@Book{Bou02,
author = {Bourbaki, Nicolas},
title = {Lie Groups and Lie Algebras: Chapters 4--6},
series = {Elements of Mathematics},
note = {Original French edition published with the title: Éléments de Matematique, Groupes et Algèbres de
Lie 4, 5, e 6, 1968. Translated by Pressley},
publisher = {Springer},
year = {2002}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Book{Bou02,
author = {Bourbaki, Nicolas},
title = {Lie Groups and Lie Algebras: Chapters 4--6},
series = {Elements of Mathematics},
note = {Original French edition published with the title: Éléments de Matematique, Groupes et Algèbres de
Lie 4, 5, e 6, 1968. Translated by Pressley},
publisher = {Springer},
year = {2002}
}
@Book{Bou02,
author = {Bourbaki, Nicolas},
title = {Lie groups and Lie algebras. Chapters 4--6},
series = {Elements of Mathematics (Berlin)},
note = {Translated from the 1968 French original by Andrew Pressley},
publisher = {Springer-Verlag, Berlin},
year = {2002},
doi = {10.1007/978-3-540-89394-3}
}

This is the mathscinet version after applying bibtool. If you like this better feel free to apply this change and proceed with merging @fingolfin. I don't care enough to block this PR over it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentle bump @fingolfin

@fingolfin fingolfin merged commit e7bcfba into master Dec 13, 2024
31 checks passed
@fingolfin fingolfin deleted the lg/cartan-type-docs branch December 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants