-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce -inf
as potential output for the dimension of an ideal
#4393
Introduce -inf
as potential output for the dimension of an ideal
#4393
Conversation
Tests seem to pass. Good to go from my side. |
-inf
-inf
as potential output for the dimension of an ideal
src/Rings/mpoly-ideals.jl
Outdated
function dim(I::MPolyIdeal) | ||
if I.dim === nothing | ||
if is_zero(ngens(base_ring(I))) # Catch a boundary case | ||
I.dim = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, is this correct if the coefficient ring is not a field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you're right. It was probably wrong before, but we should correct it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
==========================================
+ Coverage 84.38% 84.40% +0.01%
==========================================
Files 656 656
Lines 87198 87216 +18
==========================================
+ Hits 73583 73613 +30
+ Misses 13615 13603 -12
|
Address #2721 .