Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isomorphic_subgroups #4401

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ThomasBreuer
Copy link
Member

and add missing is_isomorphic method for FinGenAbGroup

and add missing `is_isomorphic` method for `FinGenAbGroup`
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (6b027f0) to head (2158b4c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Groups/homomorphisms.jl 86.36% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4401   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         656      656           
  Lines       87246    87270   +24     
=======================================
+ Hits        73640    73661   +21     
- Misses      13606    13609    +3     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.14% <100.00%> (+0.01%) ⬆️
src/Groups/homomorphisms.jl 91.73% <86.36%> (-0.22%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@mjrodgers mjrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'm assuming these two checks that fail are just flukes and will pass on another run.

@joschmitt
Copy link
Member

The book test nightly failure is #4402. I restarted the julia 1.6 job.

@fingolfin fingolfin merged commit 01f31ee into oscar-system:master Dec 13, 2024
29 of 30 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_isomorphic_subgroups branch December 13, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants