Fixed error in random_rothe_matrix
#4407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `random_rothe_matrix` into two functions for FqField and QQField case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## adv/alg-shifting-lv #4407 +/- ##
======================================================
Coverage ? 84.31%
======================================================
Files ? 656
Lines ? 87262
Branches ? 0
======================================================
Hits ? 73574
Misses ? 13688
Partials ? 0
|
|
mix up with branches, closing as no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code using
random_rothe_matrixwould fail. Additionally, split function into separate function for finite/infinite case. @antonydellavecchia