Move LieTheory serialization to src; add WeightLattice serialization
#4414
+328
−271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4414 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 658 658
Lines 87157 87133 -24
=======================================
- Hits 73550 73530 -20
+ Misses 13607 13603 -4
|
|
|
||
| function save_object(s::SerializerState, P::WeightLattice) | ||
| save_data_dict(s) do | ||
| save_typed_object(s, root_system(P), :root_system) |
There was a problem hiding this comment.
the type information for the root system will be moved out during the upcoming refactor,
If you can rewrite this so that Weight Lattice uses params, this will make the upgrade simple / virtually nothing (as in the file wont change just the code)
| end | ||
| end | ||
|
|
||
| function load_object(s::DeserializerState, ::Type{WeightLattice}) |
There was a problem hiding this comment.
this would then need to accept root system as the third parameter
| end | ||
|
|
||
| function load_object(s::DeserializerState, ::Type{WeylGroup}) | ||
| R = load_typed_object(s, :root_system) |
There was a problem hiding this comment.
similarly here, however since we could already save this, I think it's best to leave this to the refactor.
antonydellavecchia
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part was not moved as part of #4399.