Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash methods for SLPolys #4430

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Conversation

lgoettgens
Copy link
Member

Some progress towards #2222.
All of them just make use of the == definition right above.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 40 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (91f076a) to head (04b68c6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/StraightLinePrograms/lazy.jl 55.55% 28 Missing ⚠️
src/StraightLinePrograms/straightline.jl 0.00% 7 Missing ⚠️
src/Rings/slpolys.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4430      +/-   ##
==========================================
- Coverage   84.36%   84.34%   -0.02%     
==========================================
  Files         663      663              
  Lines       87805    87971     +166     
==========================================
+ Hits        74077    74200     +123     
- Misses      13728    13771      +43     
Files with missing lines Coverage Δ
src/Rings/slpolys.jl 84.83% <0.00%> (-1.78%) ⬇️
src/StraightLinePrograms/straightline.jl 86.08% <0.00%> (-1.24%) ⬇️
src/StraightLinePrograms/lazy.jl 78.03% <55.55%> (-5.01%) ⬇️

... and 6 files with indirect coverage changes

@fingolfin fingolfin merged commit e9951b9 into oscar-system:master Jan 12, 2025
25 of 27 checks passed
@lgoettgens lgoettgens deleted the lg/hash-SLP branch January 12, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants