-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] Add support for all vertical, well-quantized G4s that do not break the non-Abelian gauge group #4446
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some random comments with small improvements to allocation reduction and type stability. There are many very similar opportunities to be improved that should be tackled at some point
d24abb5
to
7255b9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4446 +/- ##
========================================
Coverage 84.39% 84.40%
========================================
Files 663 668 +5
Lines 87938 88493 +555
========================================
+ Hits 74214 74691 +477
- Misses 13724 13802 +78
|
d2c7128
to
4914e16
Compare
Thank you. I have taken your points into account. Ideally, 4914e16 should improve the code efficiency. But I am certain that there is a LOT more that could be done - in a separate PR. |
With that being said @apturner and @emikelsons , this PR should be ready for review. |
…do not break the non-Abelian gauge group
4914e16
to
ea75840
Compare
|
ea75840
to
75a0598
Compare
cc @apturner @emikelsons