Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Add support for all vertical, well-quantized G4s that do not break the non-Abelian gauge group #4446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HereAround
Copy link
Member

@HereAround HereAround marked this pull request as draft January 10, 2025 15:20
@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Jan 10, 2025
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some random comments with small improvements to allocation reduction and type stability. There are many very similar opportunities to be improved that should be tackled at some point

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 78.49462% with 40 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (43499a7) to head (d2c7128).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...al/FTheoryTools/src/G4Fluxes/special_attributes.jl 75.15% 39 Missing ⚠️
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4446    +/-   ##
========================================
  Coverage   84.39%   84.40%            
========================================
  Files         663      668     +5     
  Lines       87938    88493   +555     
========================================
+ Hits        74214    74691   +477     
- Misses      13724    13802    +78     
Files with missing lines Coverage Δ
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 100.00% <ø> (ø)
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 98.46% <100.00%> (+0.63%) ⬆️
...tal/FTheoryTools/src/HypersurfaceModels/methods.jl 100.00% <100.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 76.00% <100.00%> (ø)
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 57.69% <80.00%> (+2.37%) ⬆️
...al/FTheoryTools/src/G4Fluxes/special_attributes.jl 78.12% <75.15%> (-2.88%) ⬇️

... and 14 files with indirect coverage changes

@HereAround
Copy link
Member Author

Some random comments with small improvements to allocation reduction and type stability. There are many very similar opportunities to be improved that should be tackled at some point

Thank you. I have taken your points into account. Ideally, 4914e16 should improve the code efficiency. But I am certain that there is a LOT more that could be done - in a separate PR.

@HereAround HereAround marked this pull request as ready for review January 10, 2025 20:17
@HereAround
Copy link
Member Author

With that being said @apturner and @emikelsons , this PR should be ready for review.

@HereAround
Copy link
Member Author

HereAround commented Jan 11, 2025

I just took the liberty to push changes that hopefully will reduce the number of allocations in the computation of singular loci. A bit more tricky - postponed to the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental Only changes experimental parts of the code topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants