-
Notifications
You must be signed in to change notification settings - Fork 141
Add graph_curve(::Graph)
#4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph_curve(::Graph)
#4452
Changes from all commits
50280d3
bf0fcd3
bb1d48b
eb4aa65
2c0623c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ CurrentModule = Oscar | |
ProjectiveCurve | ||
invert_birational_map | ||
geometric_genus | ||
graph_curve | ||
``` |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,51 @@ | ||||||
@doc raw""" | ||||||
graph_curve(G::Graph) | ||||||
|
||||||
Return the graph curve of `G`, i.e., a union of lines whose dual graph is `G`, see [BE91](@cite). | ||||||
|
||||||
Assumes that `G` is trivalent and 3-connected. | ||||||
|
||||||
# Examples | ||||||
```jldoctest | ||||||
julia> G1 = vertex_edge_graph(simplex(3)) | ||||||
Undirected graph with 4 nodes and the following edges: | ||||||
(2, 1)(3, 1)(3, 2)(4, 1)(4, 2)(4, 3) | ||||||
|
||||||
julia> C1 = graph_curve(G1) | ||||||
Projective curve | ||||||
in projective 2-space over QQ with coordinates [x1, x2, x3] | ||||||
defined by ideal (x1^2*x2*x3 - x1*x2^2*x3 + x1*x2*x3^2) | ||||||
|
||||||
julia> G2 = vertex_edge_graph(cube(3)) | ||||||
Undirected graph with 8 nodes and the following edges: | ||||||
(2, 1)(3, 1)(4, 2)(4, 3)(5, 1)(6, 2)(6, 5)(7, 3)(7, 5)(8, 4)(8, 6)(8, 7) | ||||||
|
||||||
julia> C2 = graph_curve(G2) | ||||||
Projective curve | ||||||
in projective 4-space over QQ with coordinates [x1, x2, x3, x4, x5] | ||||||
defined by ideal with 5 generators | ||||||
|
||||||
``` | ||||||
""" | ||||||
function graph_curve(G::Graph; check::Bool=true) | ||||||
@req all(isequal(3),degree(G)) "G is not trivalent" | ||||||
@req connectivity(G)==3 "G is not three-connected" | ||||||
|
||||||
R,x = graded_polynomial_ring(QQ, div(nv(G), 2) + 1) | ||||||
rowOfVariables = matrix(R,[x]) | ||||||
|
||||||
cycleMatrix = kernel(matrix(QQ,signed_incidence_matrix(G)); side=:right) | ||||||
cycleMatrix = matrix(R,cycleMatrix) # converting to matrix over R for vcat below | ||||||
|
||||||
vertexIdeals = MPolyIdeal[] | ||||||
E = collect(edges(G)) | ||||||
for v in 1:n_vertices(G) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be like so? (Not sure if it ever matters... maybe for subgraphs...? Perhaps @lkastner can clarify?)
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @fingolfin Because of the following: #4426 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once #4633 is merged, this can (and should) be adapted There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for clarifying |
||||||
edgesContainingV = findall(edge->(v in edge),E) | ||||||
cycleMatrix_v = cycleMatrix[edgesContainingV,:] | ||||||
push!(vertexIdeals,ideal(minors(vcat(cycleMatrix_v,rowOfVariables),3))) | ||||||
end | ||||||
graphCurveIdeal = reduce(intersect,vertexIdeals) | ||||||
graphCurve = projective_curve(graphCurveIdeal; is_radical=true) | ||||||
|
||||||
return graphCurve | ||||||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automatic suppression of the equations in printing makes the second example lack a bit of 'content'...
If you would like to have it for testing reasons, please put it in the tests instead and test for correctness of the curve. If you consider the information as vital for users, please print at least one of the equations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will adjust the docstring accordingly.