Fix blowups along rays and singular cones #4454
Open
+92
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in the case where the ray is given by the index among the list of all cones. Also, fix star subdivision along an existing ray.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4454 +/- ##
==========================================
- Coverage 84.42% 84.42% -0.01%
==========================================
Files 668 668
Lines 88363 88374 +11
==========================================
+ Hits 74600 74608 +8
- Misses 13763 13766 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix blowups along singular cones when the cones is given by an index. Also, fix blowups and star subdivision along existing rays in the case where the ray is given by an index among the list of all cones.