fix show for AutomorphismGroup
#5165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print `Automorphism group of ...` only if the group knows that it is the *full* automorphism group of the group in question. Otherwise print `Group of automorphisms of ...`.
ThomasBreuer
added
bug
lgoettgens
reviewed
Jul 30, 2025
src/Groups/homomorphisms.jl
Outdated
| end | ||
|
|
||
| function Base.show(io::IO, ::MIME"text/plain", A::AutomorphismGroup{T}) where T <: Union{FinGenAbGroup, GAPGroup} | ||
| io = pretty(io) | ||
| println(io, "Automorphism group of", Indent()) | ||
| if hasproperty(A, :is_known_to_be_full) && A.is_known_to_be_full |
There was a problem hiding this comment.
hasproperty does not work as you want it here, as is_known_to_be_full is a bitstype. Due to being a bitstype, it gets initialized in any case (with false in this case), so any hasproperty call will return true.
There was a problem hiding this comment.
Thanks. Then everything is o.k. if I omit the hasproperty call.
There was a problem hiding this comment.
Not really: "The initial contents of a plain data type is undefined."
Now this is fixed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5165 +/- ##
=======================================
Coverage 84.88% 84.88%
=======================================
Files 710 710
Lines 95524 95519 -5
=======================================
- Hits 81082 81079 -3
+ Misses 14442 14440 -2
🚀 New features to boost your workflow:
|
"The initial contents of a plain data type is undefined."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print
Automorphism group of ...only if the group knows that it is the full automorphism group of the group in question. Otherwise printGroup of automorphisms of ....