Overhaul of Algebraic Statistics #5228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #20: the algorithm for constructing the ideal of the graph of the parametrization assumes that it is polynomial. But for, e.g., undirected Gaussian graphical models, it is rational. This is fixed by taking localizations into account explicitly.
antonydellavecchia
added
experimental
Collaborator
Author
|
Data for small phylogenetic trees and loading them will appear in a separate pr. |
antonydellavecchia
added
experimental
benlorenz
force-pushed
the
alg-stats-1.0
branch
2 times, most recently
from
8a822d1 to
8f3e403
Compare
benlorenz
force-pushed
the
alg-stats-1.0
branch
from
8f3e403 to
14dc6d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are still things to be done, but seeing as this pull request will be large I think it makes sense to get people's eyes on the changes earlier rather than later.
The main idea for the changes are that there are three (and a half) main types of graphical models and they are all subtypes of the abstract type
GraphicalModel.We introduce these types as being parametrized by their underlying graphs, but also the labels of the graph.
In this way functions can be overloaded when the graphs have certain labelings, this leads to less code duplication since users looking to extend functionality for their particular graph labelings need only overload the functions that require changes while still having access to the generic pipeline (eventually ended at taking the vanishing ideal).