TropicalGeometry: stable_intersection, added perturbation check #5272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now correct tests whether (random) perturbation is indeed generic. reruns algorithm if not.
YueRen
added
topic: tropical geometry
release notes: not needed
Member
Author
|
My students found some problem with this implementation, I will fix this and add the proper tests as soon as possible. I'll demote this PR back to a draft in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug caused by the perturbation chosen for the stable intersection not being checked for genericity (meaning the perturbed polyhedral complexes intersect in too high dimension). Bug found by @ac2368.