Skip to content

Conversation

@benlorenz
Copy link
Member

I also reordered the polyhedral helpers to fix some constructions for number field input.

@benlorenz benlorenz added topic: polyhedral geometry Issue concerns polyhedral geometry code release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Sep 26, 2025
@benlorenz benlorenz marked this pull request as draft September 26, 2025 13:42
@benlorenz
Copy link
Member Author

I need to adjust the automatic type detection a little more.

@benlorenz benlorenz marked this pull request as ready for review October 20, 2025 10:11
@benlorenz benlorenz closed this Nov 5, 2025
@benlorenz benlorenz reopened this Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.16%. Comparing base (b7fc6eb) to head (ff9e9e8).
⚠️ Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
src/PolyhedralGeometry/helpers.jl 82.97% 8 Missing ⚠️
src/PolyhedralGeometry/PolyhedralFan/properties.jl 60.00% 2 Missing ⚠️
src/PolyhedralGeometry/Cone/properties.jl 50.00% 1 Missing ⚠️
src/PolyhedralGeometry/iterators.jl 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5386      +/-   ##
==========================================
+ Coverage   84.04%   84.16%   +0.12%     
==========================================
  Files         729      730       +1     
  Lines       99064   102492    +3428     
==========================================
+ Hits        83255    86260    +3005     
- Misses      15809    16232     +423     
Files with missing lines Coverage Δ
.../ToricVarieties/NormalToricVarieties/properties.jl 90.32% <ø> (ø)
src/PolyhedralGeometry/Cone/constructors.jl 91.11% <100.00%> (ø)
.../PolyhedralGeometry/Optimization/linear_program.jl 93.33% <100.00%> (+0.11%) ⬆️
...metry/Optimization/mixed_integer_linear_program.jl 57.35% <100.00%> (+0.63%) ⬆️
...lyhedralGeometry/PolyhedralComplex/constructors.jl 96.96% <100.00%> (+1.51%) ⬆️
...PolyhedralGeometry/PolyhedralComplex/properties.jl 85.45% <100.00%> (+0.26%) ⬆️
src/PolyhedralGeometry/Polyhedron/constructors.jl 96.00% <100.00%> (+0.34%) ⬆️
...edralGeometry/Polyhedron/standard_constructions.jl 97.37% <100.00%> (-0.01%) ⬇️
...hedralGeometry/SubdivisionOfPoints/constructors.jl 82.14% <100.00%> (ø)
src/PolyhedralGeometry/triangulations.jl 97.88% <100.00%> (ø)
... and 4 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: polyhedral geometry Issue concerns polyhedral geometry code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant