Split some very long-running test files #5452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5449 and #5451, I need to repeatedly run the whole of the testsuite over and over again. To not spend too much of my lifetime, I am doing so in parallel on >40 cores.
When doing this, there are a few minutes where most cores are busy, and then one has to wait for several more minutes for the last one or two cores to finish up their task. The three test files that are touched in this PR are responsible for this, as running a single one of these test files alone needs more time than the other cores need for the rest of the testsuite.
Therefore, I propose to split these test files into smaller chunks that are easier to parallelize by our
runtest.jlscript.I would just consider this a technical maintenance change, and would thus ask @benlorenz and @fingolfin for a review.
Nonetheless, let me ping the original authors of these tests (@tom111 @annahofer00, @StevellM @simonbrandhorst, @simonbrandhorst @HechtiDerLachs) to make them aware of the changes. I did my best to somehow do a split into sensible parts (in some cases oriented by how
src/is structured, in other cases just one file per testset). If any of you are unhappy about the concrete way the split is performed, but don't object to a split in general, I would suggest that you either provide a follow-up PR to this here or an alternative one.Once this is merged, I'll experiment with putting the merge commit hash into
.git-blame-ignore-refsto keep the original history in agit blame, but I am not sure if git does understand what's going on here.