Skip to content

Some inits for realization spaces #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Some inits for realization spaces #5539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5946c56
Provide some initial values for matroid realization spaces.
HechtiDerLachs Nov 11, 2025
0c363ce
Add tests.
HechtiDerLachs Nov 11, 2025
e96f75a
Provide more reasonable initial values.
HechtiDerLachs Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions experimental/MatroidRealizationSpaces/src/realization_space.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ function realization_space_matrix(M::Matroid, B::Vector{Int}, F::Ring)
unUsedRowsForOnes = collect(2:rk)
for col in 1:(n - rk), row in 1:rk
circ = circs[col]
if !(B[row] == minimum(circ)) && B[row] in circ
if !(B[row] == minimum(circ; init=inf)) && B[row] in circ
if row in unUsedRowsForOnes
unUsedRowsForOnes = setdiff(unUsedRowsForOnes, [row])
else
Expand Down Expand Up @@ -191,7 +191,7 @@ function realization_space_matrix(M::Matroid, B::Vector{Int}, F::Ring)
circ = circs[col]
c = nonIdCols[col]

if B[row] == minimum(circ)
if B[row] == minimum(circ; init=inf)
mat[row, c] = R(1)
elseif B[row] in circ
if row in unUsedRowsForOnes
Expand Down Expand Up @@ -850,6 +850,7 @@ function reduce_realization_space(

for j in 1:n
g = gcd(Xnew[:, j]...)
is_zero(g) && continue
prime_divisors = poly_2_prime_divisors(g)
for f in prime_divisors
if f in normal_Sgens
Expand Down
5 changes: 5 additions & 0 deletions experimental/MatroidRealizationSpaces/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,8 @@ end
@test is_reduced(RS) == false
end

@testset "realization spaces with loops" begin
r = matroid_from_bases([[3,5],[3,4],[2,5],[2,4]],5)
X = realization_space(r,char=0)
end

Loading