Only run doctests for packages with enabled tests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe also add Hecke to not do this stuff. They are automatically run in the test suite on 1.10. |
lgoettgens
commented
Sep 11, 2024
|
What is the intended outcome of the changes here? |
Concrete: If I have this config file: https://github.com/Nemocas/AbstractAlgebra.jl/blob/cfdcd276e6b06f3c9c0c7c5ff71b6042656d772a/OscarCI.toml |
|
makes sense, thanks |
benlorenz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AbstractAlgebra we have different OscarDevTools-CI-jobs for Nemo, Singular, Hecke, and Oscar. However, the OscarCI job there will run the doctests of all loaded packages.
This will lead to the Hecke doctests being run two times (by HeckeCI and OscarCI), the Nemo doctests being run four times (by HeckeCI, OscarCI, NemoCI, and SingularCI). I just copied the guard from the usual test script generation from a few lines above.