Revise low_level_caller code #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fingolfin
commented
Oct 15, 2025
fingolfin
commented
- low_level_caller: don't interpolate argument tuples
- Rename some variables for clarity
- Remove dead code
- rng -> ring
- Compare to 'nothing' with ===
- low_level_caller(_rng): refactor args conversion
- Allow using low_level_caller without a lib argument
hannes14
approved these changes
Oct 16, 2025
ederc
reviewed
Oct 16, 2025
ederc
reviewed
Oct 16, 2025
ederc
reviewed
Oct 16, 2025
ederc
approved these changes
Oct 16, 2025
Avoid allocating a second Vector{Any}, the first one is sufficient.
Member
Author
|
drawback of this PR is that it changes the API used by oscar-system/Oscar.jl#5397... But perhaps we just put this into a breaking release. |
Merged
hannes14
pushed a commit
to hannes14/Singular.jl
that referenced
this pull request
Oct 23, 2025
* low_level_caller: don't interpolate argument tuples * Rename some variables for clarity * Remove dead code * rng -> ring * Compare to 'nothing' with === * low_level_caller(_rng): refactor args conversion * Allow using low_level_caller without a lib argument * low_level_caller_rng -> low_level_caller_ring * low_level_caller_ring: restrict type of 'ring' argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.