Drop address interpolations when no parent can be found #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A housenumber without the place it refers to is of only limited use.
I fixed many, should be less than 150 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an address interpolation has no parent, then results within these interpolations are displayed as ", ". That is not very helpful. Address interpolations only look for streets for parenting. We could extend this to parent to the next relevant administrative area but this would change the display name only to something like ", , ". This is better but still confusing.
There are currently about 500 interpolations without parent (of about 3million in total). That's a very small number and points rather to data issues that should be fixed. On the Nominatim side, just drop those to avoid odd results during reverse geocoding.
Fixes #3421.