Improve error handling around CLI api commands #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If close() isn't properly called, it can lead to odd error messages about uncaught exceptions.
UsageErrors are handled specially and don't show backtraces unless explicitly requested. We want the same behaviour for errors coming from the API functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds context management capability around Nominatim[Async]API objects, so that it becomes easier to properly close the connection. Without closing properly, there are sometimes odd errors around lingering database connections or unhandled exceptions. The new with construct is used in tests and in the CLI tool.
Also adds translation from nominatim_api.UsageError to nominatim_db.UsageError in the CLI tool. The latter suppresses the Python tracebacks for these errors.