Switch from pylint to flake8 for linting #3582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy is doing a superb job when it comes to detecting programming errors and buggy code. The additional issues that pylint is flagging are smaller style issues that are not without problems. The number of disabled checks has become quite long. And every version comes with new checks that breaks CI at regular intervals. At the same time pylint is severely lacking checks for PEP8 coding style, in particular, with respect to indention, white spaces and blank lines. flake8 has a much better support in that area.
This PR brings the code up to PEP8 standards and switches to flake8 for linting.
At the moment this only includes the core checks of flake8. There are a couple of interesting plugins like flake8-quote or flake8-return, which I might add in later PRs.