Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pylint to flake8 for linting #3582

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

lonvia
Copy link
Member

@lonvia lonvia commented Nov 11, 2024

mypy is doing a superb job when it comes to detecting programming errors and buggy code. The additional issues that pylint is flagging are smaller style issues that are not without problems. The number of disabled checks has become quite long. And every version comes with new checks that breaks CI at regular intervals. At the same time pylint is severely lacking checks for PEP8 coding style, in particular, with respect to indention, white spaces and blank lines. flake8 has a much better support in that area.

This PR brings the code up to PEP8 standards and switches to flake8 for linting.

At the moment this only includes the core checks of flake8. There are a couple of interesting plugins like flake8-quote or flake8-return, which I might add in later PRs.

@lonvia lonvia merged commit ae8694a into osm-search:master Nov 11, 2024
9 checks passed
@lonvia lonvia deleted the switch-to-flake branch November 11, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant