Search in settings #20016
Search in settings #20016
Conversation
|
Please follow original formatting to avoid the huge amount of changes lines: +1,598 −1,490 |
Where is the formatter I can use in Android Studio? |
|
Probably it's tab vs spaces, we use tabs by default |
ok, I changed the formatting from spaces to tabs. |
|
Anxious to see and test how this great new feature progresses. |
There was a problem hiding this comment.
There seems to a dozen or so merge conflicts preventing the merge of this PR; could you resolve those (i.e. base the PR on latest master so it applies cleanly)?
Also, I think it would help if you'd build an nightly .apk with your PR included (and publish it on your github), so interested people in #13973 could try it out and verify how it works and provide feedback (there are a lot of users willing to beta-test and few that know hot to build the app).
When those are confirmed working ok, I hope core developers will merge the PR to master, so wider community can be exposed to it.
And thanks a lot on working on this much needed improvement!
| import net.osmand.binary.BinaryMapIndexReader.SearchPoiTypeFilter; | ||
| import net.osmand.binary.BinaryMapIndexReader.SearchPoiAdditionalFilter; | ||
| import net.osmand.binary.BinaryMapIndexReader.SearchPoiTypeFilter; |
There was a problem hiding this comment.
I've noticed that there a lot superficial changes (probably done by your IDE) which only change the orders or imports. This is just one example, see https://github.com/osmandapp/OsmAnd/pull/20016/files?diff=split&w=1 for full list.
Those enlarge the diff needlessly, and make it harder to review changes. Would it be possible that you clean those up?
There was a problem hiding this comment.
Hi, the merge conflicts are resolved, imports reorganized and the apk is here: https://github.com/KnollFrank/OsmAnd/releases/download/testing/OsmAnd-nightlyFree-legacy-fat-debug.apk
…ureScreenFragment_ConfigureMap_MapSource_nonInstalledTileSource()
…gment_ConfigureMap_MapSource_nonInstalledTileSource() pass
…ilding search database
1. navigate to InstallMapLayersDialogFragment (Settings -> Driving -> Configure map -> Map source... -> Add more...) 2. select "Top Yandex RU" 3. click Apply Then "Top Yandex RU" appears in MapLayerSelectionDialogFragment (Settings -> Driving -> Configure map -> Map source...) but this new entry of MapLayerSelectionDialogFragment is not yet stored in the search database and hence can't be found via a search query.
|
@KnollFrank can you share what is the status of PR for this amazing feature? Any prognosis when it might be ready for merging? I would really love to see this land in OsmAnd! |
Hello @mnalis, I won't have access to my computer again until Monday to answer your question. |
When I click on the search magnifying glass, it takes several minutes on my smartphone for the search database to be generated before I can enter the first search query. This isn't usable. Therefore, I'm currently modifying the search library so that as many search database entries as possible can be pre-calculated, and the missing entries are only added later on the user's smartphone (e.g., preferences for a plugin that the user has activated but aren't saved in the pre-calculated search database). |
This reverts commit 60a1d72.
|
It's a shame this feature hasn't been implemented yet (At least in Beta mode). A great work of @KnollFrank and very helpful for both newbies and experienced users of the app. |
5 participants
My first attempt for ticket "Search in settings #13973"