Fix bug in geojson example, and rename some variables in examples for clarity #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
EmptyTagFilter().apply_to()
toEmptyTagFilter().enable_for()
in the GeoJSON example, so that the example works (see first commit).o
was used both for the osmium library and also for an OSM Node/Way/Relation, such that the latter sometimes shadowed the former. So I changed the examples to refer to the library by its full name, and to refer to OSM objects asn/w/a/r
if their type is known (e.g. when they are arguments to thenode/way/area/relation
handler functions). I tested all of the examples to make sure they still worked after the changes.Let me know if you have any feedback on these changes, and thanks for maintaining pyosmium.