-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/slashing accounting #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
requested review from
ethanfrey,
jawoznia,
hashedone,
uint and
JakeHartnell
and removed request for
ethanfrey and
jawoznia
October 4, 2023 13:03
maurolacy
force-pushed
the
f/slashing-accounting
branch
from
October 4, 2023 14:34
edadfce
to
93411ab
Compare
maurolacy
force-pushed
the
f/slashing-accounting
branch
from
October 6, 2023 14:35
1a165cc
to
86b8c70
Compare
maurolacy
force-pushed
the
f/slashing-accounting
branch
from
October 6, 2023 16:10
86b8c70
to
c519537
Compare
uint
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merging to avoid PR pollution / confusion. Will write tests in a follow-up. |
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes part of #128.
external-staking
slashing acct.external-staking
slashing acct tests.