Merge pull request #200 from osmosis-labs/alpo/swap-step-check

[Sumtree]: Add defense in depth check to swap steps
osmosis-labs · Jul 3, 2024 · cd637d0 · cd637d0
2 parents 6eb0431 + 25d79fa
commit cd637d0
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/contracts/sumtree-orderbook/src/order.rs b/contracts/sumtree-orderbook/src/order.rs
@@ -557,6 +557,14 @@ pub(crate) fn run_market_order_internal(
             tick_price,
             RoundingDirection::Up,
         )?;
+
+        ensure!(
+            !input_filled.is_zero(),
+            ContractError::InvalidSwap {
+                error: "Input amount for a given swap step cannot be zero".to_string()
+            }
+        );
+
         order.quantity = order
             .quantity
             // Safe conversions as amount filled should never be larger than order quantity which is upper bounded by Uint128::MAX