-
Notifications
You must be signed in to change notification settings - Fork 688
Add V31 docs #9567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add V31 docs #9567
Conversation
WalkthroughNew comprehensive upgrade guide for Osmosis mainnet transitioning from v30 to v31. Covers hardware requirements, Cosmovisor configuration, automatic and manual upgrade procedures, with explicit command sequences and TODO placeholders for upgrade height and proposal links. Static instructional documentation with no code or API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Review should verify accuracy of all command sequences, clarity of step-by-step instructions, completeness of upgrade procedures (both automatic and manual paths), appropriateness of hardware recommendations, and presence of TODO items requiring completion before publication. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
networks/osmosis-1/upgrades/v31/mainnet/guide.md (5)
53-53
: Consider using a newer Cosmovisor version.v1.0.0 is an older version; latest recommended versions are v1.4+. Pinning to v1.0.0 may miss important bug fixes and security updates. Consider using
@latest
or documenting why this specific version is required for Osmosis v31.Please verify with the Osmosis team whether v1.0.0 is intentionally required for v31 compatibility or if a newer version can be used.
73-73
: Add context forUNSAFE_SKIP_BACKUP=true
.This flag disables safety backups before upgrades. Add a brief explanation of why it's set to
true
and note the risk, or consider setting it tofalse
with guidance on backup procedures.
77-91
: Clarify repository path expectations.The instructions assume the Osmosis repository is cloned at
$HOME/osmosis
. If this is not the standard setup or if validators may have it elsewhere, consider adding a note to customize the path or verify the repository location.
102-107
: Note inconsistency with Cosmovisor build process.The Cosmovisor section uses
make build
followed by manual binary copy, while manual upgrade usesmake install
. Both are valid but document why the approaches differ, or standardize them for clarity.
94-109
: Add recommendation to test the upgrade procedure first.Best practice for mainnet validators: test the upgrade process on testnet or staging environment before performing on live infrastructure. Consider adding a note recommending this.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
networks/osmosis-1/upgrades/v31/mainnet/v31_binaries.json
is excluded by!**/*.json
📒 Files selected for processing (1)
networks/osmosis-1/upgrades/v31/mainnet/guide.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (2)
networks/osmosis-1/upgrades/v31/mainnet/guide.md (2)
9-34
: Clear and practical guidance.Hardware recommendations and swap configuration are well-documented with helpful external references.
113-116
: Good resource references.Clear pointers to official documentation and community support channels.
What is the purpose of the change
Add upgrade guide for v31
Pending Height, Proposal & Binaries
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)