-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE-659 | Update required labels #585
Conversation
Pipeline: require backport to v28.x
WalkthroughThe pull request updates the workflow configuration in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/required-labels.yml
(2 hunks)
🔇 Additional comments (1)
.github/workflows/required-labels.yml (1)
29-29
: Label requirement update looks good
The label requirement "A:backport/v28.x" correctly aligns with the PR objectives for v28.x backporting.
@@ -4,7 +4,7 @@ on: | |||
pull_request: | |||
types: [opened, labeled, unlabeled, synchronize] | |||
branches: | |||
- "v26.x" | |||
- "v27.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch targeting appears inconsistent with PR objectives
The workflow is configured to trigger on branch "v27.x", but the PR objectives mention the need for a backport to v28.x. Should this be targeting "v28.x" instead?
- branches:
- - "v27.x"
+ branches:
+ - "v28.x"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- "v27.x" | |
- "v28.x" |
Quality Gate passedIssues Measures |
Pipeline: require backport to v28.x (cherry picked from commit 7389cc7)
Pipeline: require backport to v28.x (cherry picked from commit 7389cc7) Co-authored-by: Deividas Petraitis <[email protected]>
Pipeline: require backport to v28.x
Summary by CodeRabbit