BE-636 | Fix search bug

[deividaspetraitis]

Fixes a bug when searching pool by pair of tokens for /pools endpoint

Summary by CodeRabbit

• New Features

  • Enhanced filtering mechanism for pool types, allowing for more flexible searches.
  • Improved logic for retrieving pool denoms based on pool type.

• Bug Fixes

  • Refined the GetPools method to ensure correct application of filtering and sorting.

• Chores

  • Minor variable name adjustments for clarity, improving code readability.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in the pools_usecase.go file focus on the logic for handling pool denoms within the filterExactMatchSearch and filterPartialMatchSearch functions. The implementation now includes conditional checks to differentiate between CosmWasm pools and other pool types, enhancing flexibility. Additionally, error handling in the GetAllPools method has been improved to ensure immediate error returns when the GetPool method fails. Minor comment adjustments were made for clarity, but the overall structure and functionality of the code remain unchanged.

Changes

File Path	Change Summary
pools/usecase/pools_usecase.go	- Modified logic in filterExactMatchSearch and filterPartialMatchSearch for pool denoms handling. - Implemented conditional checks for CosmWasm pools. - Enhanced error handling in GetAllPools method to return errors immediately. - Minor comment adjustments for clarity.

Possibly related PRs

• BE-636 | Fix search bug #584: The changes in this PR also modify the pools_usecase.go file, specifically in the filterExactMatchSearch and filterPartialMatchSearch functions, which are relevant to the handling of pool denoms, similar to the changes made in the main PR.

Suggested reviewers

• cryptomatictrader
• p0mvn

🐰 In the code where pools do play,
A rabbit hops to save the day.
With checks and balances in sight,
Denoms are handled just right!
Errors caught without delay,
Hooray for changes, hip-hip-hooray! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1427db0 and 92e7f3d.

📒 Files selected for processing (1)

• pools/usecase/pools_usecase.go (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on enhancing the logic within the pools_usecase.go file, specifically regarding the handling of pool metadata and filtering mechanisms. Key updates include modifications to the filterExactMatchSearch and filterPartialMatchSearch functions to better differentiate between CosmWasm pools and underlying pools. The GetPools method has also been refined to ensure proper filtering and sorting based on updated logic. Minor variable name adjustments were made for clarity, while error handling remains consistent throughout the methods.

Changes

File	Change Summary
pools/usecase/pools_usecase.go	Updated filterExactMatchSearch and filterPartialMatchSearch to differentiate pool types. Refined GetPools method for correct filtering and sorting. Minor variable name changes for clarity. Error handling maintained.

Possibly related PRs

• BE-636 | Fix search bug #584: The changes in this PR also modify the pools_usecase.go file, specifically updating the filterExactMatchSearch and filterPartialMatchSearch functions, which are directly related to the filtering logic for pools, similar to the updates made in the main PR.

Suggested reviewers

• cryptomatictrader
• p0mvn

🐰 In the meadow where pools do play,
Filtering logic finds its way.
With pools of all types, oh what a sight,
Metadata dances, making it right.
Clarity blooms, errors take flight,
A hop and a skip, all feels just right! 🌼

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1427db0 and 92e7f3d.

📒 Files selected for processing (1)

• pools/usecase/pools_usecase.go (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.