BE-691 | Implement handleCandidateRoutesInGivenOut API #617
Conversation
Implements `handleCandidateRoutesInGivenOut` API for computing exact amount out quotes. This is smaller chunk of bigger PR-607 ( #607 ) implementing computing exact amount out quotes.
WalkthroughThe pull request modifies the routing use case implementation by renaming an existing candidate route handling method to explicitly denote that it is for the "out given in" scenario, and by introducing a new method for handling candidate routes in the "in given out" context. Method signatures, calls, and accompanying comments have been updated accordingly, while the underlying caching and persistence logic remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant RouterUseCase
Client->>RouterUseCase: Request candidate routes (with tokenIn)
RouterUseCase->>RouterUseCase: Execute handleCandidateRoutesOutGivenIn
RouterUseCase-->>Client: Return candidate routes (out given in)
Client->>RouterUseCase: Request candidate routes (with tokenOut)
RouterUseCase->>RouterUseCase: Execute handleCandidateRoutesInGivenOut
RouterUseCase-->>Client: Return candidate routes (in given out)
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
router/usecase/router_usecase.go (1)
717-765: Removenolint:unusedonce the method is used.The new method implementation looks good and mirrors the structure of the "out given in" method while appropriately handling "in given out" scenarios. However, the
nolint:unuseddirective suggests this method is not yet used. Please remove this directive once the method is integrated into the codebase.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
router/usecase/export_test.gois excluded by!**/*_test.gorouter/usecase/router_usecase_test.gois excluded by!**/*_test.go
📒 Files selected for processing (1)
router/usecase/router_usecase.go(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Run linter
- GitHub Check: build
- GitHub Check: Summary
🔇 Additional comments (2)
router/usecase/router_usecase.go (2)
368-368: LGTM! Method name is now more descriptive.The rename from
handleCandidateRoutestohandleCandidateRoutesOutGivenInmakes the method's purpose clearer by explicitly indicating it handles the "out given in" scenario.
667-674: LGTM! Method name and documentation updated.The method's name and documentation have been updated to clearly indicate its purpose in handling "out given in" scenarios.
|
Implements
handleCandidateRoutesInGivenOutAPI for computing exact amount out quotes.This is smaller chunk of bigger PR-607 ( #607 ) implementing computing exact amount out quotes.
Summary by CodeRabbit
New Features
Refactor