BE-694 | Implement computeAndRankRoutesByDirectQuoteInGivenOut API #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements `rankRoutesByDirectQuoteInGivenOut` API for computing exact amount out quotes. This is smaller chunk of bigger PR-607 ( #607 ) implementing computing exact amount out quotes.
| @@ -458,6 +458,81 @@ func (r *routerUseCaseImpl) computeAndRankRoutesByDirectQuoteOutGivenIn(ctx cont | |||
| return topSingleRouteQuote, rankedRoutes, nil | |||
| } | |||
|
|
|||
| func (r *routerUseCaseImpl) computeAndRankRoutesByDirectQuoteInGivenOut(ctx context.Context, tokenOut sdk.Coin, tokenInDenom string, routingOptions domain.RouterOptions) (domain.Quote, []route.RouteImpl, error) { // nolint:unused | |||
There was a problem hiding this comment.
Note reviewer: there are no coverage of this method in this PR since it well get tested in more higher level when testing GetOptimalQuoteInGivenOut. Note that tests for #607 implementing those tests are already green ( except split routes ).
|
deividaspetraitis
changed the title
p0mvn
approved these changes
Feb 24, 2025
| } | ||
|
|
||
| if !routingOptions.DisableCache { | ||
| domain.SQSRoutesCacheWritesCounter.WithLabelValues(requestURLPath, rankedRouteCacheLabel).Inc() |
There was a problem hiding this comment.
Should we add a separate dimension for "in given out"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
computeAndRankRoutesByDirectQuoteInGivenOutAPI for computing exact amount out quotes.This is smaller chunk of bigger PR-607 ( #607 ) implementing computing exact amount out quotes.