-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various curations for edu.berkeley.cs.jqf packages #262
Conversation
f0042d5
to
fb1f5d2
Compare
curations: | ||
comment: |- | ||
Set the VCS path of the module inside the multi-module repository. | ||
See also https://github.com/rohanpadhye/JQF/tree/jqf-2.0/fuzz/pom.xml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the id
of the curation does not state a version, I'd prefer to use "master" instead of "jqf-2.0" in this link. Otherwise it looks like being specific to the "jqf-2.0" tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same applies to following commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a perma link using a SHA1 also solve the issue, @sschuberth?
This would still document based on which revision the curation has been created, and break in case of
the file location changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a perma link using a SHA1 also solve the issue, @sschuberth?
If it's a permalink that resolves to current master
, then yes. (Of course you should not simply replace the jqf-2.0
tag name with the SH1 of the commit it's pointing to.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, changed all links to permalinks with a SHA1.
…f-fuzz` Signed-off-by: Thomas Steenbergen <[email protected]>
…f-instrument` Signed-off-by: Thomas Steenbergen <[email protected]>
…f-maven-plugin` Signed-off-by: Thomas Steenbergen <[email protected]>
fb1f5d2
to
04a949f
Compare
…ey.cs.jqf:jqf-fuzz` Signed-off-by: Thomas Steenbergen <[email protected]>
…ey.cs.jqf:jqf-instrument` Signed-off-by: Thomas Steenbergen <[email protected]>
…ey.cs.jqf:jqf-maven-plugin` Signed-off-by: Thomas Steenbergen <[email protected]>
04a949f
to
66b1413
Compare
See individual commits for details.
Related to oss-review-toolkit/ort-ci-github-action#40.