Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various curations for edu.berkeley.cs.jqf packages #262

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

tsteenbe
Copy link
Member

@tsteenbe tsteenbe commented Jan 16, 2025

See individual commits for details.

Related to oss-review-toolkit/ort-ci-github-action#40.

@tsteenbe tsteenbe requested a review from a team as a code owner January 16, 2025 15:19
@tsteenbe tsteenbe force-pushed the edu.berkeley.cs.jqf-curations branch 2 times, most recently from f0042d5 to fb1f5d2 Compare January 16, 2025 15:44
curations:
comment: |-
Set the VCS path of the module inside the multi-module repository.
See also https://github.com/rohanpadhye/JQF/tree/jqf-2.0/fuzz/pom.xml.
Copy link
Member

@sschuberth sschuberth Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the id of the curation does not state a version, I'd prefer to use "master" instead of "jqf-2.0" in this link. Otherwise it looks like being specific to the "jqf-2.0" tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies to following commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a perma link using a SHA1 also solve the issue, @sschuberth?
This would still document based on which revision the curation has been created, and break in case of
the file location changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a perma link using a SHA1 also solve the issue, @sschuberth?

If it's a permalink that resolves to current master, then yes. (Of course you should not simply replace the jqf-2.0 tag name with the SH1 of the commit it's pointing to.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed all links to permalinks with a SHA1.

@tsteenbe tsteenbe force-pushed the edu.berkeley.cs.jqf-curations branch from fb1f5d2 to 04a949f Compare January 19, 2025 22:05
…ey.cs.jqf:jqf-fuzz`

Signed-off-by: Thomas Steenbergen <[email protected]>
…ey.cs.jqf:jqf-instrument`

Signed-off-by: Thomas Steenbergen <[email protected]>
…ey.cs.jqf:jqf-maven-plugin`

Signed-off-by: Thomas Steenbergen <[email protected]>
@tsteenbe tsteenbe force-pushed the edu.berkeley.cs.jqf-curations branch from 04a949f to 66b1413 Compare January 19, 2025 22:12
@tsteenbe tsteenbe merged commit 9062699 into main Jan 20, 2025
2 checks passed
@tsteenbe tsteenbe deleted the edu.berkeley.cs.jqf-curations branch January 20, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants