-
Notifications
You must be signed in to change notification settings - Fork 6
Fixes publish button #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmarHadzic
wants to merge
19
commits into
main
Choose a base branch
from
bug/publish-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes publish button #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashb196
approved these changes
May 3, 2025
rcAsironman
requested changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AmarHadzic Everything works as expected, but the only issue is that the HomeScreen still freezes. Please look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #253
What was changed
Previously, after a user clicked the "go-back arrow" button when editing a note, the
Publish button
would still appear on the homescreen instead of theadd
button. Now, theadd
button appears correctly.Why was it changed
The previous issue didn't allow the user to add/make new notes, hindering the user experience and making it an undesirable experience. With the fix, the user can make new notes after editing previous and new ones, enhancing the user experience.
How was it changed
state.routes[state.index].name === "HomeTab"
check with a full-useNavigationState inspection of the nested stackisHomeScreen
flag and based Add/Publish logic on that flagBefore clicking the add button:

After clicking the add button:

After clicking the "back" arrow button:
