Skip to content

Fixes publish button #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Fixes publish button #257

wants to merge 19 commits into from

Conversation

AmarHadzic
Copy link
Collaborator

Fix #253

What was changed
Previously, after a user clicked the "go-back arrow" button when editing a note, the Publish button would still appear on the homescreen instead of the add button. Now, the add button appears correctly.

Why was it changed
The previous issue didn't allow the user to add/make new notes, hindering the user experience and making it an undesirable experience. With the fix, the user can make new notes after editing previous and new ones, enhancing the user experience.

How was it changed

  • Replaced the simple state.routes[state.index].name === "HomeTab" check with a full-useNavigationState inspection of the nested stack
  • Added an isHomeScreen flag and based Add/Pub­lish logic on that flag

Before clicking the add button:
Simulator Screenshot - iPhone 15 Pro Max - 2025-04-28 at 00 18 36

After clicking the add button:
Simulator Screenshot - iPhone 15 Pro Max - 2025-04-28 at 00 18 56

After clicking the "back" arrow button:
Simulator Screenshot - iPhone 15 Pro Max - 2025-04-28 at 00 19 22

@AmarHadzic AmarHadzic requested a review from rcAsironman as a code owner April 28, 2025 05:19
@yashb196 yashb196 self-requested a review May 3, 2025 15:20
Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmarHadzic Everything works as expected, but the only issue is that the HomeScreen still freezes. Please look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Publish Button
3 participants