Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix SBOM-Everywhere link #4334

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

evankanderson
Copy link
Contributor

@evankanderson evankanderson commented Sep 4, 2024

I noticed this link was broken (404) when trying to follow it.

What kind of change does this PR introduce?

Docs Update

What is the current behavior?

404 on clicking the link

What is the new behavior (if this is a feature change)?**

Linking to a valid markdown document.

Which issue(s) this PR fixes

Fixes #4362

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

I noticed this link was broken (404) when trying to follow it.

Signed-off-by: Evan Anderson <[email protected]>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, two comments:

  1. The old link seems to resolve fine for me
  2. If you still want to go forward with the change, see our CONTRIBUTING.md for instructions on how to modify this file. (Or the new version from 📖 explicitly state both check documentation files are committed #4317 which hasn't been merged yet)

@spencerschrock
Copy link
Member

  1. The old link seems to resolve fine for me

Whoops, this was an error on my part. My browser was switching tabs to the new link when I pasted in the old link because I already had it open. The current link is definitely broken!

Happy to get this merged in. Can you follow the steps in Updating the docs?

@spencerschrock spencerschrock enabled auto-merge (squash) October 16, 2024 19:17
@spencerschrock spencerschrock merged commit 367426e into ossf:main Oct 16, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong link in /docs/checks.md file
2 participants