Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Tighten restrictions for running scdiff workflow #4376

Merged
merged 2 commits into from
Oct 8, 2024
Merged

🌱 Tighten restrictions for running scdiff workflow #4376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1505e1
remove ability for contributors to trigger scdiff
spencerschrock Oct 8, 2024
a051f5c
avoid race condition between scdiff comment and fetching PR head sha
spencerschrock Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/scdiff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,28 @@ jobs:
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
script: |
const allowedAssociations = ["COLLABORATOR", "CONTRIBUTOR", "MEMBER", "OWNER"];
const allowedAssociations = ["COLLABORATOR", "MEMBER", "OWNER"];
authorAssociation = '${{ github.event.comment.author_association }}'
if (!allowedAssociations.includes(authorAssociation)) {
core.setFailed("You don't have access to run scdiff");
return
}

const response = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
})

// avoid race condition between scdiff comment and fetching PR head sha
const commentTime = new Date('${{ github.event.comment.created_at }}');
const prTime = new Date(response.data.head.repo.pushed_at)
if (prTime >= commentTime) {
core.setFailed("The PR may have been updated since the scdiff request, " +
"please review any changes and relaunch if safe.");
return
}

core.setOutput('base', response.data.base.sha)
core.setOutput('head', response.data.head.sha)

Expand Down
Loading