-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add files support for Azure DevOps #4414
Conversation
7b289c9
to
c04e689
Compare
Signed-off-by: Jamie Magee <[email protected]>
c04e689
to
f4d721d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level this looks good and matches the style in the other ones, but it's also late on a Friday. Left a few comments.
Out of curiosity, how do file-only based checks look like on your test repo now? Such as License, and Binary-Artifacts?
Signed-off-by: Jamie Magee <[email protected]>
Thank you! And I completely understand.
They look good. Here's are a couple of examples No license
With license
No binary artifacts
With binary artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the examples. Just a few minor things.
They look good. Here's are a couple of examples
Unrelated to this PR, I'm surprised AZDO doesn't allow Scorecard without a token for a public repo. I can access the web GUI just fine and view commits/files. But trying to run without a token (or with an anonymose connection):
Error: scorecard.Run: internal error: ListCommits:error during commitsHandler.setup: request for commits failed with TF400813: The user 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa' is not authorized to access this resource.
Signed-off-by: Jamie Magee <[email protected]>
What kind of change does this PR introduce?
Files support for the Azure DevOps client
What is the current behavior?
ListFiles
,LocalPath
, andGetFileReader
all throw an unsupported feature error.What is the new behavior (if this is a feature change)?**
ListFiles
,LocalPath
, andGetFileReader
have implementationsWhich issue(s) this PR fixes
Next step of #4177
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)