Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set height for club card at tablet and desktop only #309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set height for club card at tablet and desktop only #309

wants to merge 2 commits into from

Conversation

csrs
Copy link
Collaborator

@csrs csrs commented Nov 2, 2019

Issue #307

This sets a height to the club card, at tablet and desktop views (when cards are displayed in rows). To test it, we'll want to add "short description" text (the text between the club name and the club page button). I tested on the live site via inspector, and it looks a little strange.
Screenshot_2019-11-01 Clubs Open Source Student Network

@csrs csrs mentioned this pull request Nov 2, 2019
Open
alexdor
alexdor requested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@alexdor alexdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this solution solves the problem, it isn't very responsive

Maybe try min-height, though that would also be a bandage to the problem and not a permanent fix

@csrs csrs self-assigned this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdor alexdor alexdor requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@csrs csrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csrs @alexdor