Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the MsSql provisioner to support optional filestream files during database restore operations. The changes make the XTP (In-Memory OLTP) file movement conditional based on whether a filestream file is specified.
Key Changes:
- Added support for optional filestream file in database restore specifications
- Made provider names unique per database instance to avoid conflicts
- Removed obsolete delete script logic from the restore process
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/apis/provisioning/v1alpha1/mssqlDatabaseTypes.go | Added LogicalFileStreamFileName field to MsSqlDatabaseRestoreSpec struct |
| internal/controllers/provisioning/provisioners/pulumi/mssql_db.go | Updated provider naming and made XTP file movement conditional based on filestream file presence |
| helm/crds/provisioning.totalsoft.ro_mssqldatabases.yaml | Added CRD schema definition for the new logicalFileStreamFileName field |
Comments suppressed due to low confidence (1)
internal/controllers/provisioning/provisioners/pulumi/mssql_db.go:1
- The
@XtpFilePathvariable is declared but only used whenLogicalFileStreamFileNameis provided. This could cause confusion or potential SQL errors if the variable is referenced but not needed. Consider declaring this variable conditionally or updating the variable name to reflect it's for generic filestream files.
package pulumi
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.