-
-
Notifications
You must be signed in to change notification settings - Fork 6
Regularized syntax #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Regularized syntax #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reid-spencer
commented
Aug 31, 2024
- Only allow brief and description values inside the block of their definition.
- Use "with" clause on leaf definitions for the "descriptives".
- Fix all test cases as a consequence
* No more brief & description after a definition * They must appear within the definition * LeafDefinitions and other elements with no children may have a "with" clause of "Descriptives" (comment, term, brief, description) This change compiles but doesn't test
* Bug was a parenting mistake * Move PrettifyCommand to commands module * Move PrettifyPass & etc. to passes module * Adjust the build.sbt to remove prettify module * Tests don't pass
* opt for a consolidated syntax * every definition of any type can be followed by `with { /* descriptives */ }`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.