Handle cases of running from systems with merged /sbin and /bin (e.g. F42+) but targeting a non-merged root #3535
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue with command execution paths when running on a merged-/usr system but targeting a non-merged-/usr root. It achieves this by using absolute paths for zipl and semodule. The changes are logical and well-motivated. I have one suggestion for ostree-bootloader-zipl.c to improve maintainability by defining a constant for the hardcoded path and adding an explanatory comment, mirroring the good practice already applied in ostree-sysroot-deploy.c.
This comment was marked as resolved.
This comment was marked as resolved.
This handles cases of running from systems with merged /sbin and /bin (e.g. F42+) but targeting a non-merged root. Signed-off-by: Colin Walters <[email protected]>
This handles cases of running from systems with merged /sbin and /bin (e.g. F42+) but targeting a non-merged root. Reported-by: Peter Colberg <[email protected]> Signed-off-by: Colin Walters <[email protected]>
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
For anyone affected by this today, a workaround is to explicitly override
$PATHinostree-finalize-staged.serviceby setting e.g.ExecSearchPath=/bin:/usr/bin:/sbin:/usr/sbin